Re: [PATCH] perf/x86/uncore: fix a potential double-free in uncore_type_init

[dinghao . liu]

> On 2023.12.05 11:27:09 +0800, Dinghao Liu wrote:
> > When kzalloc for pmus[i].boxes fails, we should clean up pmus
> > to prevent memleak. However, when kzalloc for attr_group fails,
> > pmus has been assigned to type->pmus, and freeing will be done
> > later on by the callers. The chain is: uncore_type_init ->
> > uncore_types_init -> uncore_pci_init -> uncore_types_exit ->
> > uncore_type_exit. Therefore, freeing pmus in uncore_type_init
> > may cause a double-free. Fix this by setting type->pmus to
> > NULL after kfree.
> 
> Change is ok but the call trace you wrote here is reversed or malformed??
> With that fixed or cleared.
> 

Thanks for your advice. I will fix it and resend a new patch soon.

Regards,
Dinghao