Re: [PATCH v4 md-fixes 3/3] md: fix stopping sync thread
From: kernel test robot
Date: Tue Dec 05 2023 - 04:14:44 EST
Hi Yu,
kernel test robot noticed the following build warnings:
[auto build test WARNING on song-md/md-next]
[also build test WARNING on linus/master v6.7-rc4 next-20231205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/md-fix-missing-flush-of-sync_work/20231204-215956
base: git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next
patch link: https://lore.kernel.org/r/20231204135732.3647886-4-yukuai1%40huaweicloud.com
patch subject: [PATCH v4 md-fixes 3/3] md: fix stopping sync thread
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231205/202312051758.ZlpYxGpJ-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312051758.ZlpYxGpJ-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312051758.ZlpYxGpJ-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/md/md.c: In function 'idle_sync_thread':
>> drivers/md/md.c:4897:13: warning: unused variable 'sync_seq' [-Wunused-variable]
4897 | int sync_seq = atomic_read(&mddev->sync_seq);
| ^~~~~~~~
vim +/sync_seq +4897 drivers/md/md.c
64e5e09afc14f8 Yu Kuai 2023-05-29 4894
64e5e09afc14f8 Yu Kuai 2023-05-29 4895 static void idle_sync_thread(struct mddev *mddev)
64e5e09afc14f8 Yu Kuai 2023-05-29 4896 {
130443d60b1b8c Yu Kuai 2023-05-29 @4897 int sync_seq = atomic_read(&mddev->sync_seq);
130443d60b1b8c Yu Kuai 2023-05-29 4898
6f56f0c4f1241f Yu Kuai 2023-05-29 4899 mutex_lock(&mddev->sync_mutex);
64e5e09afc14f8 Yu Kuai 2023-05-29 4900 clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
130443d60b1b8c Yu Kuai 2023-05-29 4901
fde7b408a7cb14 Yu Kuai 2023-12-04 4902 if (mddev_lock(mddev)) {
fde7b408a7cb14 Yu Kuai 2023-12-04 4903 mutex_unlock(&mddev->sync_mutex);
fde7b408a7cb14 Yu Kuai 2023-12-04 4904 return;
fde7b408a7cb14 Yu Kuai 2023-12-04 4905 }
130443d60b1b8c Yu Kuai 2023-05-29 4906
fde7b408a7cb14 Yu Kuai 2023-12-04 4907 stop_sync_thread(mddev, false, true);
6f56f0c4f1241f Yu Kuai 2023-05-29 4908 mutex_unlock(&mddev->sync_mutex);
64e5e09afc14f8 Yu Kuai 2023-05-29 4909 }
64e5e09afc14f8 Yu Kuai 2023-05-29 4910
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki