Re: [PATCH v2 12/18] sysctl: treewide: constify the ctl_table argument of handlers
From: kernel test robot
Date: Tue Dec 05 2023 - 04:50:55 EST
Hi Thomas,
kernel test robot noticed the following build errors:
[auto build test ERROR on netfilter-nf/main]
[also build test ERROR on akpm-mm/mm-everything linus/master v6.7-rc4]
[cannot apply to nf-next/master next-20231205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Wei-schuh/sysctl-delete-unused-define-SYSCTL_PERM_EMPTY_DIR/20231204-165306
base: git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git main
patch link: https://lore.kernel.org/r/20231204-const-sysctl-v2-12-7a5060b11447%40weissschuh.net
patch subject: [PATCH v2 12/18] sysctl: treewide: constify the ctl_table argument of handlers
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20231205/202312051727.wW4EJo6e-lkp@xxxxxxxxx/config)
compiler: s390-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312051727.wW4EJo6e-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312051727.wW4EJo6e-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
arch/s390/appldata/appldata_base.c: In function 'appldata_register_ops':
>> arch/s390/appldata/appldata_base.c:363:40: error: assignment to 'int (*)(const struct ctl_table *, int, void *, size_t *, loff_t *)' {aka 'int (*)(const struct ctl_table *, int, void *, long unsigned int *, long long int *)'} from incompatible pointer type 'int (*)(struct ctl_table *, int, void *, size_t *, loff_t *)' {aka 'int (*)(struct ctl_table *, int, void *, long unsigned int *, long long int *)'} [-Werror=incompatible-pointer-types]
363 | ops->ctl_table[0].proc_handler = appldata_generic_handler;
| ^
cc1: some warnings being treated as errors
vim +363 arch/s390/appldata/appldata_base.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 340
^1da177e4c3f41 Linus Torvalds 2005-04-16 341
^1da177e4c3f41 Linus Torvalds 2005-04-16 342 /************************* module-ops management *****************************/
^1da177e4c3f41 Linus Torvalds 2005-04-16 343 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 344 * appldata_register_ops()
^1da177e4c3f41 Linus Torvalds 2005-04-16 345 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 346 * update ops list, register /proc/sys entries
^1da177e4c3f41 Linus Torvalds 2005-04-16 347 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 348 int appldata_register_ops(struct appldata_ops *ops)
^1da177e4c3f41 Linus Torvalds 2005-04-16 349 {
13f8b7c5e6fa13 Roel Kluin 2008-10-28 350 if (ops->size > APPLDATA_MAX_REC_SIZE)
37e3a6ac5a3046 Heiko Carstens 2007-11-20 351 return -EINVAL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 352
fdd9da76e2dec0 Joel Granados 2023-10-02 353 ops->ctl_table = kcalloc(1, sizeof(struct ctl_table), GFP_KERNEL);
37e3a6ac5a3046 Heiko Carstens 2007-11-20 354 if (!ops->ctl_table)
^1da177e4c3f41 Linus Torvalds 2005-04-16 355 return -ENOMEM;
^1da177e4c3f41 Linus Torvalds 2005-04-16 356
b1ad171efa089a Gerald Schaefer 2009-04-23 357 mutex_lock(&appldata_ops_mutex);
^1da177e4c3f41 Linus Torvalds 2005-04-16 358 list_add(&ops->list, &appldata_ops_list);
b1ad171efa089a Gerald Schaefer 2009-04-23 359 mutex_unlock(&appldata_ops_mutex);
^1da177e4c3f41 Linus Torvalds 2005-04-16 360
7db12246306ea6 Luis Chamberlain 2023-03-10 361 ops->ctl_table[0].procname = ops->name;
7db12246306ea6 Luis Chamberlain 2023-03-10 362 ops->ctl_table[0].mode = S_IRUGO | S_IWUSR;
7db12246306ea6 Luis Chamberlain 2023-03-10 @363 ops->ctl_table[0].proc_handler = appldata_generic_handler;
7db12246306ea6 Luis Chamberlain 2023-03-10 364 ops->ctl_table[0].data = ops;
^1da177e4c3f41 Linus Torvalds 2005-04-16 365
9edbfe92a0a135 Joel Granados 2023-08-09 366 ops->sysctl_header = register_sysctl_sz(appldata_proc_name, ops->ctl_table, 1);
37e3a6ac5a3046 Heiko Carstens 2007-11-20 367 if (!ops->sysctl_header)
37e3a6ac5a3046 Heiko Carstens 2007-11-20 368 goto out;
^1da177e4c3f41 Linus Torvalds 2005-04-16 369 return 0;
37e3a6ac5a3046 Heiko Carstens 2007-11-20 370 out:
b1ad171efa089a Gerald Schaefer 2009-04-23 371 mutex_lock(&appldata_ops_mutex);
37e3a6ac5a3046 Heiko Carstens 2007-11-20 372 list_del(&ops->list);
b1ad171efa089a Gerald Schaefer 2009-04-23 373 mutex_unlock(&appldata_ops_mutex);
37e3a6ac5a3046 Heiko Carstens 2007-11-20 374 kfree(ops->ctl_table);
37e3a6ac5a3046 Heiko Carstens 2007-11-20 375 return -ENOMEM;
^1da177e4c3f41 Linus Torvalds 2005-04-16 376 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 377
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki