Re: [PATCH v3] regulator: event: Add regulator netlink event support

[Naresh Solanki]

Hi

On Tue, 5 Dec 2023 at 04:54, Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Tue, Nov 28, 2023 at 02:07:16PM +0000, Naresh Solanki wrote:
> > This commit introduces netlink event support to the regulator subsystem.
> >
> > Changes:
> > - Introduce event.c and regnl.h for netlink event handling.
> > - Implement reg_generate_netlink_event to broadcast regulator events.
> > - Update Makefile to include the new event.c file.
>
> This looks good however it breaks an allmodconfig build:
>
>    ERROR: modpost: missing MODULE_LICENSE() in drivers/regulator/event.o
>
> > +config REGULATOR_NETLINK_EVENTS
> > +     tristate "Enable support for receiving regulator events via netlink"
> > +     depends on NET
>
> I think this needs to be a bool (NET is a bool so there's no dependency
> issues there hopefully).
Thanks for pointing this out. I missed testing build with allmodconfig.
As suggested, after updating Kconfig from tristate to bool this
issue got resolved.

Will push v4  with the fix.

Regards,
Naresh

>
> Thanks for pushing this forwards.