Re: [PATCH 1/4] dt-bindings: clock: sophgo: Add CV1800 bindings

[Inochi Amaoto]

>
>On 05/12/2023 10:43, Inochi Amaoto wrote:
>> Add definition for the clock controller of the CV1800 series SoC.
>>
>
>If there is going to be resend:
>
>A nit, subject: drop second/last, redundant "bindings". The
>"dt-bindings" prefix is already stating that these are bindings.
>

OK, thanks.

>> Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxxxx>
>> Link: https://github.com/milkv-duo/duo-files/blob/main/hardware/CV1800B/CV1800B-CV1801B-Preliminary-Datasheet-full-en.pdf
>> ---
>
>
>> diff --git a/include/dt-bindings/clock/sophgo,cv1800.h b/include/dt-bindings/clock/sophgo,cv1800.h
>> new file mode 100644
>> index 000000000000..6a9897b34978
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/sophgo,cv1800.h
>> @@ -0,0 +1,174 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>
>Why not dual-license? Checkpatch complains about this, so are you sure
>you run it?
>

Yes, I have run it. It seems I misunderstood the warning message.
It only tells me it should be (GPL-2.0-only OR .*). And I think
GPL-2.0 is ok. Thanks for your explanation, I will fix this soon.

>
>Best regards,
>Krzysztof
>
>