Re: [PATCH v7 06/12] iommu: Remove iommu_[un]register_device_fault_handler()

[Baolu Lu]

On 2023/12/4 20:36, Yi Liu wrote:
> >   /**
> >    * iommu_report_device_fault() - Report fault event to device driver
> >    * @dev: the device
> > @@ -1395,10 +1325,6 @@ int iommu_report_device_fault(struct device 
> > *dev, struct iommu_fault_event *evt)
> >       /* we only report device fault if there is a handler registered */
> >       mutex_lock(&param->lock);
> >       fparam = param->fault_param;
> > -    if (!fparam || !fparam->handler) {
>
> should it still check the fparam?

Yes.

Best regards,
baolu