Re: [PATCH v7 03/12] iommu: Remove unrecoverable fault data

[Baolu Lu]

On 2023/12/4 18:58, Yi Liu wrote:
> On 2023/11/15 11:02, Lu Baolu wrote:
> > The unrecoverable fault data is not used anywhere. Remove it to avoid
> > dead code.
> >
> > Suggested-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> > Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> > Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> > Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> > ---
> >   include/linux/iommu.h | 70 +------------------------------------------
> >   1 file changed, 1 insertion(+), 69 deletions(-)
> >
> > diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> > index c2e2225184cf..81eee1afec72 100644
> > --- a/include/linux/iommu.h
> > +++ b/include/linux/iommu.h
> > @@ -50,69 +50,9 @@ struct iommu_dma_cookie;
> >   /* Generic fault types, can be expanded IRQ remapping fault */
> >   enum iommu_fault_type {
> > -    IOMMU_FAULT_DMA_UNRECOV = 1,    /* unrecoverable fault */
> >       IOMMU_FAULT_PAGE_REQ,        /* page request fault */
>
> a nit, do you kno why this enum was starting from 1? Should it still
> start from 1 after deleting UNRECOV?

As Jason suggested in another thread, we will address this issue in
another thread. I am not sure for now whether we will remove the fault
type field or re-use the previous scheme.

Best regards,
baolu