Re: [PATCH] net: ___neigh_lookup_noref(): remove redundant parameters

From: kernel test robot
Date: Tue Dec 05 2023 - 07:41:29 EST

Next message: kernel test robot: "drivers/firmware/efi/libstub/arm32-stub.c:12:28: sparse: sparse: symbol 'efi_entry_state' was not declared. Should it be static?"
Previous message: Yu Kuai: "[PATCH -next RFC 14/14] nilfs2: use bdev api in nilfs_attach_log_writer()"
In reply to: kernel test robot: "Re: [PATCH] net: ___neigh_lookup_noref(): remove redundant parameters"
Next in thread: kernel test robot: "Re: [PATCH] net: ___neigh_lookup_noref(): remove redundant parameters"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi YangXin,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]
[also build test ERROR on net/main linus/master v6.7-rc4 next-20231205]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/YangXin/net-___neigh_lookup_noref-remove-redundant-parameters/20231205-030205
base: net-next/main
patch link: https://lore.kernel.org/r/20231204185943.68-1-yx.0xffff%40gmail.com
patch subject: [PATCH] net: ___neigh_lookup_noref(): remove redundant parameters
config: arm-defconfig (https://download.01.org/0day-ci/archive/20231205/202312052000.xiZkoBI4-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312052000.xiZkoBI4-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312052000.xiZkoBI4-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

In file included from net/socket.c:108:
In file included from include/net/busy_poll.h:18:
In file included from include/net/ip.h:30:
In file included from include/net/route.h:28:
>> include/net/arp.h:27:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&arp_tbl, neigh_key_eq32, &key, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
In file included from net/socket.c:108:
In file included from include/net/busy_poll.h:18:
In file included from include/net/ip.h:30:
In file included from include/net/route.h:29:
>> include/net/ndisc.h:383:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
In file included from net/socket.c:108:
In file included from include/net/busy_poll.h:18:
In file included from include/net/ip.h:30:
In file included from include/net/route.h:29:
include/net/ndisc.h:390:73: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(ipv6_stub->nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
3 errors generated.
--
In file included from net/core/neighbour.c:30:
>> include/net/arp.h:27:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&arp_tbl, neigh_key_eq32, &key, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
1 error generated.
--
In file included from net/ipv4/route.c:86:
In file included from include/net/dst_metadata.h:6:
In file included from include/net/ip_tunnels.h:18:
In file included from include/net/lwtunnel.h:9:
In file included from include/net/route.h:28:
>> include/net/arp.h:27:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&arp_tbl, neigh_key_eq32, &key, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
In file included from net/ipv4/route.c:86:
In file included from include/net/dst_metadata.h:6:
In file included from include/net/ip_tunnels.h:18:
In file included from include/net/lwtunnel.h:9:
In file included from include/net/route.h:29:
>> include/net/ndisc.h:383:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
In file included from net/ipv4/route.c:86:
In file included from include/net/dst_metadata.h:6:
In file included from include/net/ip_tunnels.h:18:
In file included from include/net/lwtunnel.h:9:
In file included from include/net/route.h:29:
include/net/ndisc.h:390:73: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(ipv6_stub->nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
net/ipv4/route.c:880:6: warning: variable 'log_martians' set but not used [-Wunused-but-set-variable]
int log_martians;
^
1 warning and 3 errors generated.
--
In file included from net/ipv4/igmp.c:91:
>> include/net/arp.h:27:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&arp_tbl, neigh_key_eq32, &key, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
In file included from net/ipv4/igmp.c:92:
In file included from include/net/ip.h:30:
In file included from include/net/route.h:29:
>> include/net/ndisc.h:383:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
In file included from net/ipv4/igmp.c:92:
In file included from include/net/ip.h:30:
In file included from include/net/route.h:29:
include/net/ndisc.h:390:73: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(ipv6_stub->nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
net/ipv4/igmp.c:1915:6: warning: variable 'changerec' set but not used [-Wunused-but-set-variable]
int changerec = 0;
^
1 warning and 3 errors generated.
--
In file included from net/ipv6/anycast.c:37:
>> include/net/ndisc.h:383:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
In file included from net/ipv6/anycast.c:37:
include/net/ndisc.h:390:73: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(ipv6_stub->nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
In file included from net/ipv6/anycast.c:39:
In file included from include/net/ip6_route.h:9:
In file included from include/net/lwtunnel.h:9:
In file included from include/net/route.h:28:
>> include/net/arp.h:27:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&arp_tbl, neigh_key_eq32, &key, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
3 errors generated.
--
In file included from net/ipv6/ip6_fib.c:29:
In file included from include/net/ip.h:30:
In file included from include/net/route.h:28:
>> include/net/arp.h:27:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&arp_tbl, neigh_key_eq32, &key, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
In file included from net/ipv6/ip6_fib.c:29:
In file included from include/net/ip.h:30:
In file included from include/net/route.h:29:
>> include/net/ndisc.h:383:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
In file included from net/ipv6/ip6_fib.c:29:
In file included from include/net/ip.h:30:
In file included from include/net/route.h:29:
include/net/ndisc.h:390:73: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(ipv6_stub->nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
net/ipv6/ip6_fib.c:1384:25: warning: variable 'pn' set but not used [-Wunused-but-set-variable]
struct fib6_node *fn, *pn = NULL;
^
1 warning and 3 errors generated.
--
In file included from net/ipv6/sysctl_net_ipv6.c:15:
>> include/net/ndisc.h:383:63: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(&nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
In file included from net/ipv6/sysctl_net_ipv6.c:15:
include/net/ndisc.h:390:73: error: too many arguments to function call, expected 3, have 4
return ___neigh_lookup_noref(ipv6_stub->nd_tbl, neigh_key_eq128, pkey, dev);
~~~~~~~~~~~~~~~~~~~~~ ^~~
include/net/neighbour.h:293:33: note: '___neigh_lookup_noref' declared here
static inline struct neighbour *___neigh_lookup_noref(
^
2 errors generated.

vim +27 include/net/arp.h

20
21 #ifdef CONFIG_INET
22 static inline struct neighbour *__ipv4_neigh_lookup_noref(struct net_device *dev, u32 key)
23 {
24 if (dev->flags & (IFF_LOOPBACK | IFF_POINTOPOINT))
25 key = INADDR_ANY;
26
> 27 return ___neigh_lookup_noref(&arp_tbl, neigh_key_eq32, &key, dev);
28 }
29 #else
30 static inline
31 struct neighbour *__ipv4_neigh_lookup_noref(struct net_device *dev, u32 key)
32 {
33 return NULL;
34 }
35 #endif
36

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Next message: kernel test robot: "drivers/firmware/efi/libstub/arm32-stub.c:12:28: sparse: sparse: symbol 'efi_entry_state' was not declared. Should it be static?"
Previous message: Yu Kuai: "[PATCH -next RFC 14/14] nilfs2: use bdev api in nilfs_attach_log_writer()"
In reply to: kernel test robot: "Re: [PATCH] net: ___neigh_lookup_noref(): remove redundant parameters"
Next in thread: kernel test robot: "Re: [PATCH] net: ___neigh_lookup_noref(): remove redundant parameters"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]