Re: [PATCH] ath5k: remove unused ath5k_eeprom_info::ee_antenna

[Jiri Slaby]

On 05. 12. 23, 13:07, Kalle Valo wrote:
> "Jiri Slaby (SUSE)" <jirislaby@xxxxxxxxxx> writes:
>
> > clang-struct [1] found that ee_antenna in struct ath5k_eeprom_info is
> > unused. The commit 1048643ea94d ("ath5k: Clean up eeprom
> > parsing and add missing calibration data") added it, but did not use it
> > in any way. Neither, there is a later user.
> >
> > So remove that unused member.
> >
> > [1] https://github.com/jirislaby/clang-struct
>
> clang-struct looks really nice, especially if it can also find unused
> structures.

It can...

> What about unused defines or enums, any chance to find those
> in the future? :)

All of that is IMO possible (I'm not completely sure about macros, 
despite clang ASTs provide a lot of info. Incl. info about them and 
their expansion).

It's all limited only by man-force: me.

thanks,
--
js
suse labs