[PATCH] watchdog: Provide a better stop error message

From: Prarit Bhargava
Date: Tue Dec 05 2023 - 09:10:26 EST


Provide a better stop error message for the case where the watchdog does
not stop.

CC: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>
CC: Guenter Roeck <linux@xxxxxxxxxxxx>
CC: David Arcari <darcari@xxxxxxxxxx>
CC: linux-watchdog@xxxxxxxxxxxxxxx
Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>
---
drivers/watchdog/watchdog_dev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
index 15df74e11a59..f0084bf7c750 100644
--- a/drivers/watchdog/watchdog_dev.c
+++ b/drivers/watchdog/watchdog_dev.c
@@ -965,7 +965,8 @@ static int watchdog_release(struct inode *inode, struct file *file)

/* If the watchdog was not stopped, send a keepalive ping */
if (err < 0) {
- pr_crit("watchdog%d: watchdog did not stop!\n", wdd->id);
+ pr_crit("watchdog%d is still active. Stop by [%s:%d] failed.\n",
+ wdd->id, current->comm, current->pid);
watchdog_ping(wdd);
}

--
2.43.0