Re: [PATCH] mm: init_mlocked_on_free
From: kernel test robot
Date: Tue Dec 05 2023 - 12:23:13 EST
Hi York,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 4e87148f80d198ba5febcbcc969c6b9471099a09]
url: https://github.com/intel-lab-lkp/linux/commits/York-Jasper-Niebuhr/mm-init_mlocked_on_free/20231202-214431
base: 4e87148f80d198ba5febcbcc969c6b9471099a09
patch link: https://lore.kernel.org/r/20231202134218.151074-1-yjnworkstation%40gmail.com
patch subject: [PATCH] mm: init_mlocked_on_free
config: i386-randconfig-141-20231203 (https://download.01.org/0day-ci/archive/20231206/202312060005.VsdhiMtz-lkp@xxxxxxxxx/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312060005.VsdhiMtz-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312060005.VsdhiMtz-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> mm/mlock.c:301: warning: Function parameter or member 'cofinit' not described in 'munlock_folio'
vim +301 mm/mlock.c
7225522bb429a2f Vlastimil Babka 2013-09-11 295
2fbb0c10d1e8222 Hugh Dickins 2022-02-14 296 /**
96f97c438f61ddb Lorenzo Stoakes 2023-01-12 297 * munlock_folio - munlock a folio
96f97c438f61ddb Lorenzo Stoakes 2023-01-12 298 * @folio: folio to be munlocked, either normal or a THP head.
5b40998ae35cf64 Vlastimil Babka 2013-09-11 299 */
9cdd4fc5d036cbe York Jasper Niebuhr 2023-12-02 300 void munlock_folio(struct folio *folio, int cofinit)
2fbb0c10d1e8222 Hugh Dickins 2022-02-14 @301 {
90d07210ab55e45 Lorenzo Stoakes 2023-01-12 302 struct folio_batch *fbatch;
56afe477df3cbbc Vlastimil Babka 2013-09-11 303
90d07210ab55e45 Lorenzo Stoakes 2023-01-12 304 local_lock(&mlock_fbatch.lock);
90d07210ab55e45 Lorenzo Stoakes 2023-01-12 305 fbatch = this_cpu_ptr(&mlock_fbatch.fbatch);
5b40998ae35cf64 Vlastimil Babka 2013-09-11 306 /*
90d07210ab55e45 Lorenzo Stoakes 2023-01-12 307 * folio_test_clear_mlocked(folio) must be left to __munlock_folio(),
90d07210ab55e45 Lorenzo Stoakes 2023-01-12 308 * which will check whether the folio is multiply mlocked.
5b40998ae35cf64 Vlastimil Babka 2013-09-11 309 */
90d07210ab55e45 Lorenzo Stoakes 2023-01-12 310 folio_get(folio);
90d07210ab55e45 Lorenzo Stoakes 2023-01-12 311 if (!folio_batch_add(fbatch, folio) ||
90d07210ab55e45 Lorenzo Stoakes 2023-01-12 312 folio_test_large(folio) || lru_cache_disabled())
9cdd4fc5d036cbe York Jasper Niebuhr 2023-12-02 313 mlock_folio_batch(fbatch, cofinit);
90d07210ab55e45 Lorenzo Stoakes 2023-01-12 314 local_unlock(&mlock_fbatch.lock);
7a8010cd36273ff Vlastimil Babka 2013-09-11 315 }
56afe477df3cbbc Vlastimil Babka 2013-09-11 316
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki