Re: [PATCH] net: phy: Only resume phy if it is suspended

From: Justin Chen
Date: Tue Dec 05 2023 - 19:10:56 EST




On 12/5/23 4:03 PM, Andrew Lunn wrote:
On Tue, Dec 05, 2023 at 03:42:29PM -0800, Justin Chen wrote:
Resuming the phy can take quite a bit of time. Lets only resume the
phy if it is suspended.

Humm...

https://lore.kernel.org/netdev/6d45f4da-c45e-4d35-869f-85dd4ec37b31@xxxxxxx/T/

If Broadcom PHYs are slow to resume, maybe you should solve this in
the broadcom resume handler, read the status from the hardware and
only do the resume if the hardware is suspended.

Andrew

Right... Guess this won't work. It is odd that during resume we call __phy_resume twice. Once from phy_resume() and another at phy_start(). Let me rethink this. Thanks for the feedback.

Justin

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature