Re: [PATCH net 2/2] net: hns: fix fake link up on xge port
From: kernel test robot
Date: Tue Dec 05 2023 - 20:23:07 EST
Hi Jijie,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net/main]
url: https://github.com/intel-lab-lkp/linux/commits/Jijie-Shao/net-hns-fix-wrong-head-when-modify-the-tx-feature-when-sending-packets/20231201-183325
base: net/main
patch link: https://lore.kernel.org/r/20231201102703.4134592-3-shaojijie%40huawei.com
patch subject: [PATCH net 2/2] net: hns: fix fake link up on xge port
config: i386-buildonly-randconfig-001-20231202 (https://download.01.org/0day-ci/archive/20231206/202312060909.F00QN1zB-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312060909.F00QN1zB-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312060909.F00QN1zB-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c:69:6: warning: no previous prototype for function 'hns_mac_link_anti_shake' [-Wmissing-prototypes]
void hns_mac_link_anti_shake(struct mac_driver *mac_ctrl_drv, u32 *link_status)
^
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c:69:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void hns_mac_link_anti_shake(struct mac_driver *mac_ctrl_drv, u32 *link_status)
^
static
1 warning generated.
vim +/hns_mac_link_anti_shake +69 drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
68
> 69 void hns_mac_link_anti_shake(struct mac_driver *mac_ctrl_drv, u32 *link_status)
70 {
71 #define HNS_MAC_LINK_WAIT_TIME 5
72 #define HNS_MAC_LINK_WAIT_CNT 40
73
74 int i;
75
76 if (!mac_ctrl_drv->get_link_status) {
77 *link_status = 0;
78 return;
79 }
80
81 for (i = 0; i < HNS_MAC_LINK_WAIT_CNT; i++) {
82 msleep(HNS_MAC_LINK_WAIT_TIME);
83 mac_ctrl_drv->get_link_status(mac_ctrl_drv, link_status);
84 if (!*link_status)
85 break;
86 }
87 }
88
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki