Re: [PATCH v2] scsi: zfcp: Replace strlcpy() with strscpy()

From: Martin K. Petersen
Date: Tue Dec 05 2023 - 20:54:05 EST



Kees,

> strlcpy() reads the entire source buffer first. This read may exceed
> the destination size limit. This is both inefficient and can lead to
> linear read overflows if a source string is not NUL-terminated[1].
> Additionally, it returns the size of the source string, not the
> resulting size of the destination string. In an effort to remove
> strlcpy() completely[2], replace strlcpy() here with strscpy().

Applied to 6.8/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering