RE: [EXT] Re: [PATCH] wifi: mwifiex: added extra delay for firmware ready.

From: David Lin
Date: Tue Dec 05 2023 - 21:19:32 EST


> From: Brian Norris <briannorris@xxxxxxxxxxxx>
> Sent: Wednesday, December 6, 2023 4:27 AM
> To: David Lin <yu-hao.lin@xxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Pete Hsieh
> <tsung-hsien.hsieh@xxxxxxx>
> Subject: [EXT] Re: [PATCH] wifi: mwifiex: added extra delay for firmware ready.
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Tue, Nov 28, 2023 at 04:25:44PM +0800, David Lin wrote:
> > For SDIO IW416, in a corner case FW may return ready before complete
> > full initialization.
> > Command timeout may occur at driver load after reboot.
>
> Do you have any idea why? Is it specific to this chip and/or firmware?
> I'm hesitant to add magic sleeps to everything, just because you have one
> buggy chip/firmware.
>
> If it's a known issue with a single chip, it seems like you should add a flag to
> struct mwifiex_sdio_device / mwifiex_sdio_sd8978.
>

This issue is reported by customer
We confirmed it's specific to this chip and 100ms is sufficient and relatively safe/easy then change FW.

Will add flag to struct mwifiex_sdio_device / mwifiex_sdio_sd8978

> Brian
>
> > Workaround by adding 100ms delay at checking FW status.
> >
> > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx>