Re: [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it

[George Stark]

Hello Christophe

Thanks for the review

On 12/5/23 02:09, Christophe Leroy wrote:
> Le 04/12/2023 à 19:05, George Stark a écrit :
> > In the probe() callback in case of error mutex is destroyed being locked
> > which is not allowed so unlock the mute before destroying.
>
> Should there be a fixes: tag ? For instance on 59ea3c9faf32 ("leds: add
> aw2013 driver") ?
Ack

> > Signed-off-by: George Stark <gnstark@xxxxxxxxxxxxxxxxx>
> > ---
> >    drivers/leds/leds-aw2013.c | 1 +
> >    1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/leds/leds-aw2013.c b/drivers/leds/leds-aw2013.c
> > index 59765640b70f..c2bc0782c0cd 100644
> > --- a/drivers/leds/leds-aw2013.c
> > +++ b/drivers/leds/leds-aw2013.c
> > @@ -397,6 +397,7 @@ static int aw2013_probe(struct i2c_client *client)
> >    	regulator_disable(chip->vcc_regulator);
> >    
> >    error:
> > +	mutex_unlock(&chip->mutex);
> >    	mutex_destroy(&chip->mutex);
> >    	return ret;
> >    }

--
Best regards
George