RE: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define

From: Arun.Ramadoss
Date: Wed Dec 06 2023 - 03:59:19 EST


Hi Sean,

> -----Original Message-----
> From: Sean Nyekjaer <sean@xxxxxxxxxx>
> Sent: Wednesday, December 6, 2023 12:55 PM
> To: Woojung Huh - C21699 <Woojung.Huh@xxxxxxxxxxxxx>;
> UNGLinuxDriver <UNGLinuxDriver@xxxxxxxxxxxxx>; Andrew Lunn
> <andrew@xxxxxxx>; Florian Fainelli <f.fainelli@xxxxxxxxx>; Vladimir Oltean
> <olteanv@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> Paolo Abeni <pabeni@xxxxxxxxxx>; Arun Ramadoss - I17769
> <Arun.Ramadoss@xxxxxxxxxxxxx>
> Cc: Sean Nyekjaer <sean@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without
> _VALUE define
>
> [Some people who received this message don't often get email from
> sean@xxxxxxxxxx. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> DSA_TAG_PROTO_LAN937X to improve readability.
>
> Fixes: 99b16df0cd52 ("net: dsa: microchip: lan937x: add dsa_tag_protocol")
> Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>

Not sure, whether it is a bug fix or not. Since it only improves readability.
I believe it should point to net-next.