Re: [PATCH] fs/namei: Don't update atime when some errors occur in get_link

From: Hao Ge
Date: Wed Dec 06 2023 - 04:03:01 EST




> On Dec 5, 2023, at 19:07, Christian Brauner <brauner@xxxxxxxxxx> wrote:
>
> On Tue, Dec 05, 2023 at 03:17:33PM +0800, Hao Ge wrote:
>> Perhaps we have some errors occur(like security),then we don't update
>> atime,because we didn't actually access it
>>
>> Signed-off-by: Hao Ge <gehao@xxxxxxxxxx>
>> ---
>
> We didn't follow the link but we accessed it. I guess it's not completey
> clear what's correct here so I'd just leave it as is.
Hi brauner
Thank your for your reply.
I just thought of a situation that user access a link failed due to some error(like permission issue),maybe report some error to user, actually user don’t get anything,but atime still update.
Maybe your are right,after all,we still tried to visit.
Thanks
Best Regards
Hao