Re: [PATCH v2 1/4] dt-bindings: clock: sophgo: Add clock controller of CV1800 series SoC

From: Krzysztof Kozlowski
Date: Wed Dec 06 2023 - 05:28:42 EST


On 06/12/2023 03:04, Inochi Amaoto wrote:
>>>> +
>>>> + clock-names:
>>>> + items:
>>>> + - const: osc
>>>
>>> You have one clock, why do you need a name?
>>
>> I am not pretty familiar with this. I just wrote this binding by
>> referencing others. Maybe use "maxItems: 1" is just fine?

No, just drop clock-names and get clocks by indices in the driver.

>>
>
> I have referenced this name in the clk_parent_data as the global clock
> parent. Removing this will cause driver broken.

It's not related.

Best regards,
Krzysztof