Re: [PATCH v2 0/2] Add HX83102j driver for HIMAX HID touchscreen

[Krzysztof Kozlowski]

On 06/12/2023 11:35, Allen_Lin wrote:
> Hi,
> This driver implements for HIMAX HID touchscreen HX8310XX series. 
> 
> Using SPI interface to acquire HID packets from driver. 
> 
> Patchs notes as below 
> 1. Add the Maintainer and devicetree bindings document for driver
> 2. Add the driver code and modify Kconfig/Makefiles to support the driver
> 
> change in v2 :
> - Fix kernel test robot build warnings.

I reviewed v1, so you must fix everything I pointed out. This code is in
absolutely terrible shape. It way over complicated, with way too many
structures, way too many abstractions (you must have exactly 0
abstractions). It was not written in Linux style.

Best regards,
Krzysztof