RE: [PATCH] crypto: virtio-crypto: Handle dataq logic with tasklet

From: Gonglei (Arei)
Date: Wed Dec 06 2023 - 06:47:50 EST


Hi Herbert,

> -----Original Message-----
> From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx]
> Sent: Friday, December 1, 2023 6:11 PM
> To: Gonglei (Arei) <arei.gonglei@xxxxxxxxxx>
> Cc: linux-crypto@xxxxxxxxxxxxxxx; pasic@xxxxxxxxxxxxx; mst@xxxxxxxxxx;
> jasowang@xxxxxxxxxx; virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; wangyangxin <wangyangxin1@xxxxxxxxxx>;
> Gonglei (Arei) <arei.gonglei@xxxxxxxxxx>
> Subject: Re: [PATCH] crypto: virtio-crypto: Handle dataq logic with tasklet
>
> Gonglei Arei <arei.gonglei@xxxxxxxxxx> wrote:
> > Doing ipsec produces a spinlock recursion warning.
> > This is due to crypto_finalize_request() being called in the upper half.
> > Move virtual data queue processing of virtio-crypto driver to tasklet.
> >
> > Fixes: dbaf0624ffa57 ("crypto: add virtio-crypto driver")
> > Reported-by: Halil Pasic <pasic@xxxxxxxxxxxxx>
> > Signed-off-by: wangyangxin <wangyangxin1@xxxxxxxxxx>
> > Signed-off-by: Gonglei <arei.gonglei@xxxxxxxxxx>
> > ---
> > drivers/crypto/virtio/virtio_crypto_common.h | 2 ++
> > drivers/crypto/virtio/virtio_crypto_core.c | 23 +++++++++++++----------
> > 2 files changed, 15 insertions(+), 10 deletions(-)
>
> Patch applied. Thanks.

Sorry, pls apply version 2 if possible.

Regards,
-Gonglei

> --
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt