Re: [PATCH 2/2] membarrier: riscv: Provide core serializing command

From: Palmer Dabbelt
Date: Wed Dec 06 2023 - 09:16:17 EST


On Wed, 06 Dec 2023 06:11:07 PST (-0800), parri.andrea@xxxxxxxxx wrote:
I see

$ git grep "config MEMBARRIER" fab957c11efe2f405e08b9f0d080524bc2631428
fab957c11efe2f405e08b9f0d080524bc2631428:init/Kconfig:config MEMBARRIER

so IMO this is just one of those forever bugs. So I'd lean towards

Fixes: fab957c11efe ("RISC-V: Atomic and Locking Code")

Works for me, will apply in v2.


(or anything in that original patch set). It's not that big of a backport,
so I think it's safe enough?

Indeed, I think so.

The final version of this fix will likely depend on some machinery/code
introduced by 3ccfebedd8cf54 ("powerpc, membarrier: Skip memory barrier
in switch_mm()"); but, yes, nothing we can't safely adjust I think.

Ya, I guess we'll have to look to know for sure but hopefully it's manageable.

Thanks,
Andrea