Re: [PATCH] drm/bridge: nxp-ptn3460: simplify some error checking

From: Robert Foss
Date: Wed Dec 06 2023 - 10:49:27 EST


On Wed, 6 Dec 2023 18:05:15 +0300, Dan Carpenter wrote:
> The i2c_master_send/recv() functions return negative error codes or
> they return "len" on success. So the error handling here can be written
> as just normal checks for "if (ret < 0) return ret;". No need to
> complicate things.
>
> Btw, in this code the "len" parameter can never be zero, but even if
> it were, then I feel like this would still be the best way to write it.
>
> [...]

Added suggested by tag, to reflect Neils feedback.

Applied, thanks!

[1/1] drm/bridge: nxp-ptn3460: simplify some error checking
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=28d3d0696688



Rob