Re: [PATCH 6/6] perf mem: Remove useless header files for X86

[Liang, Kan]

On 2023-12-06 3:38 p.m., Arnaldo Carvalho de Melo wrote:
> Em Wed, Dec 06, 2023 at 12:13:24PM -0800, kan.liang@xxxxxxxxxxxxxxx escreveu:
>> From: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
>>
>> The X86 mem-events.c only has perf_mem_events array now. Remove useless
>> header files.
> 
> It would be great that those were removed while you made the cleanups,
> i.e. removed the need for one of them, remove it together with the
> refactorings, etc.
> 
> But I don't think this is a requirement, just would make it cleaner.

Sure, I will merge it with the previous patch in V2.

Thanks,
Kan
> 
> Will wait for reviews now.
> 
> - Arnaldo
>  
>> Signed-off-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
>> ---
>>  tools/perf/arch/x86/util/mem-events.c | 10 ++++------
>>  1 file changed, 4 insertions(+), 6 deletions(-)
>>
>> diff --git a/tools/perf/arch/x86/util/mem-events.c b/tools/perf/arch/x86/util/mem-events.c
>> index 71ffe16de751..62df03e91c7e 100644
>> --- a/tools/perf/arch/x86/util/mem-events.c
>> +++ b/tools/perf/arch/x86/util/mem-events.c
>> @@ -1,11 +1,9 @@
>>  // SPDX-License-Identifier: GPL-2.0
>> -#include "util/pmu.h"
>> -#include "util/pmus.h"
>> -#include "util/env.h"
>> -#include "map_symbol.h"
>> -#include "mem-events.h"
>>  #include "linux/string.h"
>> -#include "env.h"
>> +#include "util/map_symbol.h"
>> +#include "util/mem-events.h"
>> +#include "mem-events.h"
>> +
>>  
>>  #define MEM_LOADS_AUX		0x8203
>>  
>> -- 
>> 2.35.1
>>
>