Re: [PATCH 5/6] dt-bindings: watchdog: samsung: add specific compatible for Tesla FSD

From: Rob Herring
Date: Wed Dec 06 2023 - 17:05:28 EST



On Tue, 05 Dec 2023 10:22:28 +0100, Krzysztof Kozlowski wrote:
> Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the
> others it reuses several devices from older designs. Historically we
> kept the old (block's) compatible only. This works fine and there is no
> bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add Tesla FSD compatible specific to be used with an existing fallback.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> I propose to take the patch through Samsung SoC (me). See cover letter
> for explanation.
> ---
> .../bindings/watchdog/samsung-wdt.yaml | 21 ++++++++++++-------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>

Acked-by: Rob Herring <robh@xxxxxxxxxx>