Re: [PATCH] ASoC: audio-graph-card2: fix off by one in graph_parse_node_multi_nm()

[Kuninori Morimoto]

Hi Dan

> The > comparison should be >= to avoid writing one element beyond the end
> of the dai_link->ch_maps[] array.  The dai_link->ch_maps[] array is
> allocated in graph_parse_node_multi() and it has "nm_max" elements.
> 
> Fixes: e2de6808df4a ("ASoC: audio-graph-card2: add CPU:Codec = N:M support")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

> In this same function I was also concerned about these conditions:
> 
> if (cpu_idx > dai_link->num_cpus)
> if (codec_idx > dai_link->num_codecs)
> 
> But I wasn't able to see out how those idx variables are actually
> used.

These also ">=" I think.

Thank you for pointing it

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto