Re: [PATCH] usb: cdns3: starfive: don't misuse /** comment

From: Peter Chen
Date: Wed Dec 06 2023 - 22:00:39 EST


On Thu, Dec 7, 2023 at 2:13 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> Use a common C comment "/*" instead of "/**" to prevent a warning
> from scripts/kernel-doc.
>
> cdns3-starfive.c:23: warning: expecting prototype for cdns3(). Prototype was for USB_STRAP_HOST() instead
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
> Cc: Peter Chen <peter.chen@xxxxxxxxxx>
> Cc: Pawel Laszczak <pawell@xxxxxxxxxxx>
> Cc: Roger Quadros <rogerq@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> ---

Acked-by: Peter Chen <peter.chen@xxxxxxxxxx>

Peter


> drivers/usb/cdns3/cdns3-starfive.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/usb/cdns3/cdns3-starfive.c b/drivers/usb/cdns3/cdns3-starfive.c
> --- a/drivers/usb/cdns3/cdns3-starfive.c
> +++ b/drivers/usb/cdns3/cdns3-starfive.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0
> -/**
> +/*
> * cdns3-starfive.c - StarFive specific Glue layer for Cadence USB Controller
> *
> * Copyright (C) 2023 StarFive Technology Co., Ltd.