Re: [PATCH v4 06/10] drm/panel: Add Synaptics R63353 panel driver
From: Dan Carpenter
Date: Thu Dec 07 2023 - 00:26:25 EST
Hi Dario,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Dario-Binacchi/drm-bridge-Fix-bridge-disable-logic/20231205-185455
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20231205105341.4100896-7-dario.binacchi%40amarulasolutions.com
patch subject: [PATCH v4 06/10] drm/panel: Add Synaptics R63353 panel driver
config: i386-randconfig-r071-20231206 (https://download.01.org/0day-ci/archive/20231207/202312070214.Eyi9T4eq-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231207/202312070214.Eyi9T4eq-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202312070214.Eyi9T4eq-lkp@xxxxxxxxx/
smatch warnings:
drivers/gpu/drm/panel/panel-synaptics-r63353.c:132 r63353_panel_activate() warn: missing unwind goto?
vim +132 drivers/gpu/drm/panel/panel-synaptics-r63353.c
64f91a53613aea Michael Trimarchi 2023-12-05 107 static int r63353_panel_activate(struct r63353_panel *rpanel)
64f91a53613aea Michael Trimarchi 2023-12-05 108 {
64f91a53613aea Michael Trimarchi 2023-12-05 109 struct mipi_dsi_device *dsi = rpanel->dsi;
64f91a53613aea Michael Trimarchi 2023-12-05 110 struct device *dev = &dsi->dev;
64f91a53613aea Michael Trimarchi 2023-12-05 111 int i, ret;
64f91a53613aea Michael Trimarchi 2023-12-05 112
64f91a53613aea Michael Trimarchi 2023-12-05 113 ret = mipi_dsi_dcs_soft_reset(dsi);
64f91a53613aea Michael Trimarchi 2023-12-05 114 if (ret < 0) {
64f91a53613aea Michael Trimarchi 2023-12-05 115 dev_err(dev, "Failed to do Software Reset (%d)\n", ret);
64f91a53613aea Michael Trimarchi 2023-12-05 116 goto fail;
64f91a53613aea Michael Trimarchi 2023-12-05 117 }
64f91a53613aea Michael Trimarchi 2023-12-05 118
64f91a53613aea Michael Trimarchi 2023-12-05 119 usleep_range(15000, 17000);
64f91a53613aea Michael Trimarchi 2023-12-05 120
64f91a53613aea Michael Trimarchi 2023-12-05 121 ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
64f91a53613aea Michael Trimarchi 2023-12-05 122 if (ret < 0) {
64f91a53613aea Michael Trimarchi 2023-12-05 123 dev_err(dev, "Failed to enter sleep mode (%d)\n", ret);
64f91a53613aea Michael Trimarchi 2023-12-05 124 goto fail;
64f91a53613aea Michael Trimarchi 2023-12-05 125 }
64f91a53613aea Michael Trimarchi 2023-12-05 126
64f91a53613aea Michael Trimarchi 2023-12-05 127 for (i = 0; i < rpanel->pdata->init_length; i++) {
64f91a53613aea Michael Trimarchi 2023-12-05 128 const struct r63353_instr *instr = &rpanel->pdata->init[i];
64f91a53613aea Michael Trimarchi 2023-12-05 129
64f91a53613aea Michael Trimarchi 2023-12-05 130 ret = mipi_dsi_dcs_write_buffer(dsi, instr->data, instr->len);
64f91a53613aea Michael Trimarchi 2023-12-05 131 if (ret < 0)
64f91a53613aea Michael Trimarchi 2023-12-05 @132 return ret;
goto fail?
64f91a53613aea Michael Trimarchi 2023-12-05 133 }
64f91a53613aea Michael Trimarchi 2023-12-05 134
64f91a53613aea Michael Trimarchi 2023-12-05 135 msleep(120);
64f91a53613aea Michael Trimarchi 2023-12-05 136
64f91a53613aea Michael Trimarchi 2023-12-05 137 ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
64f91a53613aea Michael Trimarchi 2023-12-05 138 if (ret < 0) {
64f91a53613aea Michael Trimarchi 2023-12-05 139 dev_err(dev, "Failed to exit sleep mode (%d)\n", ret);
64f91a53613aea Michael Trimarchi 2023-12-05 140 goto fail;
64f91a53613aea Michael Trimarchi 2023-12-05 141 }
64f91a53613aea Michael Trimarchi 2023-12-05 142
64f91a53613aea Michael Trimarchi 2023-12-05 143 usleep_range(5000, 10000);
64f91a53613aea Michael Trimarchi 2023-12-05 144
64f91a53613aea Michael Trimarchi 2023-12-05 145 ret = mipi_dsi_dcs_set_display_on(dsi);
64f91a53613aea Michael Trimarchi 2023-12-05 146 if (ret < 0) {
64f91a53613aea Michael Trimarchi 2023-12-05 147 dev_err(dev, "Failed to set display ON (%d)\n", ret);
64f91a53613aea Michael Trimarchi 2023-12-05 148 goto fail;
64f91a53613aea Michael Trimarchi 2023-12-05 149 }
64f91a53613aea Michael Trimarchi 2023-12-05 150
64f91a53613aea Michael Trimarchi 2023-12-05 151 return 0;
64f91a53613aea Michael Trimarchi 2023-12-05 152
64f91a53613aea Michael Trimarchi 2023-12-05 153 fail:
64f91a53613aea Michael Trimarchi 2023-12-05 154 gpiod_set_value(rpanel->reset_gpio, 0);
64f91a53613aea Michael Trimarchi 2023-12-05 155
64f91a53613aea Michael Trimarchi 2023-12-05 156 return ret;
64f91a53613aea Michael Trimarchi 2023-12-05 157 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki