RE: [PATCH v2 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs

From: James Tai [戴志峰]
Date: Thu Dec 07 2023 - 01:02:07 EST


Hi Krzysztof,

>>
>> misc_irq_mux: misc_irq_mux@80 {
>> compatible = "realtek,rtd1619b-intc-misc";
>> reg = <0x00 0x80>;
>> interrupts-extended = <&gic GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
>> <&gic GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>,
>> <&gic GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,
>> interrupt-controller;
>> #address-cells = <0>;
>> #interrupt-cells = <1>;
>> };
>
>So you have strictly defined number of interrupts and the actual interrupts per
>variant.
>
Yes, I have defined them.

>>
>>>
>>> Look at all other bindings covering multiple devices and their
>>> clocks/interrupts/interconnects/reg etc.
>>
>> May I adopt the approach used in this YAML for my case?
>> https://www.kernel.org/doc/Documentation/devicetree/bindings/timer/all
>> winner%2Csun4i-a10-timer.yaml
>
>
>I am asking for this since few emails.
>
>Look:
>"Anyway, you must describe the items. Why this is not fixed but flexible?
>Hardware has different number of pins? That's unlikely."
>
It is fixed, and the hardware has the same number of pins.

Regards,
James