Re: [PATCH RESEND] drm/exynos: dpi: Change connector type to DPI

From: Paul Cercueil
Date: Thu Dec 07 2023 - 04:16:48 EST


Le jeudi 07 décembre 2023 à 11:42 +0900, 대인기/Tizen Platform
Lab(SR)/삼성전자 a écrit :
> Hi Paul,
>
> > -----Original Message-----
> > From: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> > Sent: Thursday, December 7, 2023 7:19 AM
> > To: Inki Dae <inki.dae@xxxxxxxxxxx>; Seung-Woo Kim
> > <sw0312.kim@xxxxxxxxxxx>; Kyungmin Park
> > <kyungmin.park@xxxxxxxxxxx>;
> > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; Alim Akhtar
> > <alim.akhtar@xxxxxxxxxxx>
> > Cc: David Airlie <airlied@xxxxxxxxx>; Daniel Vetter
> > <daniel@xxxxxxxx>;
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx;
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> > linux-samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > Paul
> > Cercueil <paul@xxxxxxxxxxxxxxx>
> > Subject: [PATCH RESEND] drm/exynos: dpi: Change connector type to
> > DPI
> >
> > When exynos_drm_dpi.c was written, DRM_MODE_CONNECTOR_DPI did not
> > exist
> > yet and I guess that's the reason why DRM_MODE_CONNECTOR_VGA was
> > used as
> > the connector type.
> >
> > However, now it makes more sense to use DRM_MODE_CONNECTOR_DPI as
> > the
> > connector type.
>
> Sorry for late. Merged.

No problem. Thank you!

Cheers,
-Paul

>
> Thanks,
> Inki Dae
>
> >
> > Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/exynos/exynos_drm_dpi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
> > b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
> > index 378e5381978f..0dc36df6ada3 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
> > @@ -101,7 +101,7 @@ static int exynos_dpi_create_connector(struct
> > drm_encoder *encoder)
> >
> >   ret = drm_connector_init(encoder->dev, connector,
> >   &exynos_dpi_connector_funcs,
> > - DRM_MODE_CONNECTOR_VGA);
> > + DRM_MODE_CONNECTOR_DPI);
> >   if (ret) {
> >   DRM_DEV_ERROR(ctx->dev,
> >         "failed to initialize connector with
> > drm\n");
> > --
> > 2.42.0
> >
>
>