Re: [PATCH v3 1/4] dt-bindings: arm: Add remote etm dt-binding

From: Krzysztof Kozlowski
Date: Thu Dec 07 2023 - 04:39:28 EST


On 06/12/2023 15:14, Mao Jinlong wrote:
> Remote ETM(Embedded Trace Macrocell) is to capture information of
> the executed processor instructions of remote processors like modem.
> Add new coresight-remote-etm.yaml file describing the bindings
> required to define coresight remote etm in the device trees.
>


> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + etm {
> + compatible = "qcom,coresight-remote-etm";

Now something happened with your indentation here... was it like this
before? The guideline asks to use 2 or 4 space indentation for the
example, while 4 is preferred.

With fixed indentation in the example:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>


Best regards,
Krzysztof