Re: [PATCH 23/27] tty: serdev: convert to u8 and size_t

[Greg KH]

On Thu, Dec 07, 2023 at 09:19:29AM +0100, Johan Hovold wrote:
> On Thu, Dec 07, 2023 at 10:47:18AM +0900, Greg Kroah-Hartman wrote:
> > On Wed, Dec 06, 2023 at 09:09:46AM +0100, Johan Hovold wrote:
> > > On Wed, Dec 06, 2023 at 08:37:08AM +0100, Jiri Slaby wrote:
> 
> > > > diff --git a/drivers/gnss/serial.c b/drivers/gnss/serial.c
> > > > index 5d8e9bfb24d0..baa956494e79 100644
> > > > --- a/drivers/gnss/serial.c
> > > > +++ b/drivers/gnss/serial.c
> > > > @@ -80,8 +80,8 @@ static const struct gnss_operations gnss_serial_gnss_ops = {
> > > >  	.write_raw	= gnss_serial_write_raw,
> > > >  };
> > > >  
> > > > -static int gnss_serial_receive_buf(struct serdev_device *serdev,
> > > > -					const unsigned char *buf, size_t count)
> > > > +static ssize_t gnss_serial_receive_buf(struct serdev_device *serdev,
> > > > +				       const u8 *buf, size_t count)
> 
> > > The gnss subsystem consistently use tabs-only for indentation of
> > > continuation lines so please don't change the indentation for these
> > > files.
> > 
> > That's going to drive checkpatch.pl crazy, please don't inist on it as
> > that is not going to work well over time as we would all have to
> > remember that just for this one subsystem :(
> 
> Open-parenthesis alignment is not part of the coding standard and is
> hidden behind the checkpatch.pl --strict option along with other (often
> excessive) checks that are not generally agreed upon.
> 
> Only staging and networking enable that option by default and I think
> checkpatch.pl handles that transparently.

Ah, didn't realize this was a staging-only thing, sorry.  As that's what
I get loads of checkpatch fixes for, I figured it was what everyone
should be using :)

thanks,

greg k-h