Re: [PATCH 16/27] tty: mmc: sdio: use u8 for flag

From: Ulf Hansson
Date: Thu Dec 07 2023 - 09:11:08 EST


On Wed, 6 Dec 2023 at 08:37, Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx> wrote:
>
> Switch character types to u8. To conform to characters in the rest of
> the tty layer.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: linux-mmc@xxxxxxxxxxxxxxx

Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Kind regards
Uffe

> ---
> drivers/mmc/core/sdio_uart.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/sdio_uart.c b/drivers/mmc/core/sdio_uart.c
> index 370fadf1d6d1..575ebbce378e 100644
> --- a/drivers/mmc/core/sdio_uart.c
> +++ b/drivers/mmc/core/sdio_uart.c
> @@ -354,12 +354,11 @@ static void sdio_uart_stop_rx(struct sdio_uart_port *port)
>
> static void sdio_uart_receive_chars(struct sdio_uart_port *port, u8 *status)
> {
> - unsigned int flag;
> int max_count = 256;
>
> do {
> u8 ch = sdio_in(port, UART_RX);
> - flag = TTY_NORMAL;
> + u8 flag = TTY_NORMAL;
> port->icount.rx++;
>
> if (unlikely(*status & (UART_LSR_BI | UART_LSR_PE |
> --
> 2.43.0
>