Re: [PATCH v4 4/4] nvme: repack struct nvme_ns_head

From: Christoph Hellwig
Date: Thu Dec 07 2023 - 10:33:58 EST


On Thu, Dec 07, 2023 at 01:36:24PM +0100, Daniel Wagner wrote:
> ns_id, lba_shift and ms are always accessed for every read/write I/O in
> nvme_setup_rw. By grouping these variables into one cacheline we can
> safe some cycles.
>
> 4k sequential reads:
>
> baseline patched
> Bandwidth: 1620 1634
> IOPs 66345579 66910939

Nice:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>