Re: [PATCH v1 01/10] usb: typec: bus: provide transmit type for alternate mode drivers
From: kernel test robot
Date: Thu Dec 07 2023 - 16:07:06 EST
Hi RD,
kernel test robot noticed the following build errors:
[auto build test ERROR on 5e4c8814a431d21bfaf20b464134f40f2f81e152]
url: https://github.com/intel-lab-lkp/linux/commits/RD-Babiera/usb-typec-bus-provide-transmit-type-for-alternate-mode-drivers/20231207-171114
base: 5e4c8814a431d21bfaf20b464134f40f2f81e152
patch link: https://lore.kernel.org/r/20231207090738.15721-13-rdbabiera%40google.com
patch subject: [PATCH v1 01/10] usb: typec: bus: provide transmit type for alternate mode drivers
config: arm-defconfig (https://download.01.org/0day-ci/archive/20231208/202312080453.iQ1jSiLY-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231208/202312080453.iQ1jSiLY-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312080453.iQ1jSiLY-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/platform/chrome/cros_typec_vdm.c:89:82: error: too few arguments to function call, expected 5, have 4
ret = typec_altmode_vdm(amode, hdr, &resp.vdm_response[1], resp.vdm_data_objects);
~~~~~~~~~~~~~~~~~ ^
include/linux/usb/typec_altmode.h:84:5: note: 'typec_altmode_vdm' declared here
int typec_altmode_vdm(struct typec_altmode *altmode,
^
1 error generated.
vim +89 drivers/platform/chrome/cros_typec_vdm.c
f54c013e7eef29 Prashant Malani 2023-01-26 55
50ed638bbc47ba Prashant Malani 2022-12-28 56 /*
50ed638bbc47ba Prashant Malani 2022-12-28 57 * Retrieves a VDM response from the EC and forwards it to the altmode driver based on SVID.
50ed638bbc47ba Prashant Malani 2022-12-28 58 */
50ed638bbc47ba Prashant Malani 2022-12-28 59 void cros_typec_handle_vdm_response(struct cros_typec_data *typec, int port_num)
50ed638bbc47ba Prashant Malani 2022-12-28 60 {
50ed638bbc47ba Prashant Malani 2022-12-28 61 struct ec_response_typec_vdm_response resp;
50ed638bbc47ba Prashant Malani 2022-12-28 62 struct ec_params_typec_vdm_response req = {
50ed638bbc47ba Prashant Malani 2022-12-28 63 .port = port_num,
50ed638bbc47ba Prashant Malani 2022-12-28 64 };
50ed638bbc47ba Prashant Malani 2022-12-28 65 struct typec_altmode *amode;
50ed638bbc47ba Prashant Malani 2022-12-28 66 u16 svid;
50ed638bbc47ba Prashant Malani 2022-12-28 67 u32 hdr;
50ed638bbc47ba Prashant Malani 2022-12-28 68 int ret;
50ed638bbc47ba Prashant Malani 2022-12-28 69
50ed638bbc47ba Prashant Malani 2022-12-28 70 ret = cros_ec_cmd(typec->ec, 0, EC_CMD_TYPEC_VDM_RESPONSE, &req,
50ed638bbc47ba Prashant Malani 2022-12-28 71 sizeof(req), &resp, sizeof(resp));
50ed638bbc47ba Prashant Malani 2022-12-28 72 if (ret < 0) {
50ed638bbc47ba Prashant Malani 2022-12-28 73 dev_warn(typec->dev, "Failed VDM response fetch, port: %d\n", port_num);
50ed638bbc47ba Prashant Malani 2022-12-28 74 return;
50ed638bbc47ba Prashant Malani 2022-12-28 75 }
50ed638bbc47ba Prashant Malani 2022-12-28 76
50ed638bbc47ba Prashant Malani 2022-12-28 77 hdr = resp.vdm_response[0];
50ed638bbc47ba Prashant Malani 2022-12-28 78 svid = PD_VDO_VID(hdr);
50ed638bbc47ba Prashant Malani 2022-12-28 79 dev_dbg(typec->dev, "Received VDM header: %x, port: %d\n", hdr, port_num);
50ed638bbc47ba Prashant Malani 2022-12-28 80
50ed638bbc47ba Prashant Malani 2022-12-28 81 amode = typec_match_altmode(typec->ports[port_num]->port_altmode, CROS_EC_ALTMODE_MAX,
50ed638bbc47ba Prashant Malani 2022-12-28 82 svid, PD_VDO_OPOS(hdr));
50ed638bbc47ba Prashant Malani 2022-12-28 83 if (!amode) {
50ed638bbc47ba Prashant Malani 2022-12-28 84 dev_err(typec->dev, "Received VDM for unregistered altmode (SVID:%x), port: %d\n",
50ed638bbc47ba Prashant Malani 2022-12-28 85 svid, port_num);
50ed638bbc47ba Prashant Malani 2022-12-28 86 return;
50ed638bbc47ba Prashant Malani 2022-12-28 87 }
50ed638bbc47ba Prashant Malani 2022-12-28 88
50ed638bbc47ba Prashant Malani 2022-12-28 @89 ret = typec_altmode_vdm(amode, hdr, &resp.vdm_response[1], resp.vdm_data_objects);
50ed638bbc47ba Prashant Malani 2022-12-28 90 if (ret)
50ed638bbc47ba Prashant Malani 2022-12-28 91 dev_err(typec->dev, "Failed to forward VDM to altmode (SVID:%x), port: %d\n",
50ed638bbc47ba Prashant Malani 2022-12-28 92 svid, port_num);
50ed638bbc47ba Prashant Malani 2022-12-28 93 }
50ed638bbc47ba Prashant Malani 2022-12-28 94
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki