Re: [PATCH] ring-buffer: Add offset of events in dump on mismatch
From: Mathieu Desnoyers
Date: Thu Dec 07 2023 - 17:19:34 EST
On 2023-12-07 17:16, Steven Rostedt wrote:
[...]
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 8d2a4f00eca9..b10deb8a5647 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -3424,23 +3424,27 @@ static void dump_buffer_page(struct buffer_data_page *bpage,
case RINGBUF_TYPE_TIME_EXTEND:
delta = rb_event_time_stamp(event);
ts += delta;
- pr_warn(" [%lld] delta:%lld TIME EXTEND\n", ts, delta);
+ pr_warn(" %x: [%lld] delta:%lld TIME EXTEND\n",
Please prefix hex values with "0x", as in:
pr_warn(" 0x%x: [%lld] delta:%lld TIME EXTEND\n"
Otherwise it can be confusing.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com