Re: [PATCH v2 1/2] kunit: tool: fix parsing of test attributes

From: David Gow
Date: Thu Dec 07 2023 - 22:07:30 EST


On Fri, 8 Dec 2023 at 05:34, Rae Moar <rmoar@xxxxxxxxxx> wrote:
>
> Add parsing of attributes as diagnostic data. Fixes issue with test plan
> being parsed incorrectly as diagnostic data when located after
> suite-level attributes.
>
> Note that if there does not exist a test plan line, the diagnostic lines
> between the suite header and the first result will be saved in the suite
> log rather than the first test case log.
>
> Signed-off-by: Rae Moar <rmoar@xxxxxxxxxx>
> ---

Thanks, this looks good to me.

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>

Cheers,
-- David