Re: [PATCH v2 1/1] i2c: busses: i2c-mv64xxx: fix arb-loss i2c lock
From: kernel test robot
Date: Thu Dec 07 2023 - 23:16:22 EST
Hi Elad,
kernel test robot noticed the following build warnings:
[auto build test WARNING on wsa/i2c/for-next]
[also build test WARNING on linus/master v6.7-rc4 next-20231207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Elad-Nachman/i2c-busses-i2c-mv64xxx-fix-arb-loss-i2c-lock/20231208-005406
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
patch link: https://lore.kernel.org/r/20231207165027.2628302-2-enachman%40marvell.com
patch subject: [PATCH v2 1/1] i2c: busses: i2c-mv64xxx: fix arb-loss i2c lock
config: i386-buildonly-randconfig-004-20231208 (https://download.01.org/0day-ci/archive/20231208/202312081143.38GWJJ2J-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231208/202312081143.38GWJJ2J-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312081143.38GWJJ2J-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/i2c/busses/i2c-mv64xxx.c:440:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
if (!ret) {
^~~
drivers/i2c/busses/i2c-mv64xxx.c:372:12: note: initialize the variable 'ret' to silence this warning
int i, ret;
^
= 0
1 warning generated.
vim +/ret +440 drivers/i2c/busses/i2c-mv64xxx.c
367
368 static void
369 mv64xxx_i2c_do_action(struct mv64xxx_i2c_data *drv_data)
370 {
371 struct pinctrl *pc;
372 int i, ret;
373
374 switch(drv_data->action) {
375 case MV64XXX_I2C_ACTION_SEND_RESTART:
376 /* We should only get here if we have further messages */
377 BUG_ON(drv_data->num_msgs == 0);
378
379 drv_data->msgs++;
380 drv_data->num_msgs--;
381 mv64xxx_i2c_send_start(drv_data);
382
383 if (drv_data->errata_delay)
384 udelay(5);
385
386 /*
387 * We're never at the start of the message here, and by this
388 * time it's already too late to do any protocol mangling.
389 * Thankfully, do not advertise support for that feature.
390 */
391 drv_data->send_stop = drv_data->num_msgs == 1;
392 break;
393
394 case MV64XXX_I2C_ACTION_CONTINUE:
395 writel(drv_data->cntl_bits,
396 drv_data->reg_base + drv_data->reg_offsets.control);
397 break;
398
399 case MV64XXX_I2C_ACTION_SEND_ADDR_1:
400 writel(drv_data->addr1,
401 drv_data->reg_base + drv_data->reg_offsets.data);
402 writel(drv_data->cntl_bits,
403 drv_data->reg_base + drv_data->reg_offsets.control);
404 break;
405
406 case MV64XXX_I2C_ACTION_SEND_ADDR_2:
407 writel(drv_data->addr2,
408 drv_data->reg_base + drv_data->reg_offsets.data);
409 writel(drv_data->cntl_bits,
410 drv_data->reg_base + drv_data->reg_offsets.control);
411 break;
412
413 case MV64XXX_I2C_ACTION_SEND_DATA:
414 writel(drv_data->msg->buf[drv_data->byte_posn++],
415 drv_data->reg_base + drv_data->reg_offsets.data);
416 writel(drv_data->cntl_bits,
417 drv_data->reg_base + drv_data->reg_offsets.control);
418 break;
419
420 case MV64XXX_I2C_ACTION_RCV_DATA:
421 drv_data->msg->buf[drv_data->byte_posn++] =
422 readl(drv_data->reg_base + drv_data->reg_offsets.data);
423 writel(drv_data->cntl_bits,
424 drv_data->reg_base + drv_data->reg_offsets.control);
425 break;
426
427 case MV64XXX_I2C_ACTION_UNLOCK_BUS:
428 if (!drv_data->soft_reset)
429 break;
430
431 pc = devm_pinctrl_get(drv_data->adapter.dev.parent);
432 if (IS_ERR(pc)) {
433 dev_err(&drv_data->adapter.dev,
434 "failed to get pinctrl for bus unlock!\n");
435 break;
436 }
437
438 /* Change i2c MPPs state to act as GPIOs: */
439 if (pinctrl_select_state(pc, drv_data->i2c_gpio_state) >= 0) {
> 440 if (!ret) {
441 /*
442 * Toggle i2c scl (serial clock) 10 times.
443 * 10 clocks are enough to transfer a full
444 * byte plus extra as seen from tests with
445 * Ubiquity SFP module causing the issue.
446 * This allows the slave that occupies
447 * the bus to transmit its remaining data,
448 * so it can release the i2c bus:
449 */
450 for (i = 0; i < 10; i++) {
451 gpio_set_value(drv_data->scl_gpio, 1);
452 udelay(100);
453 gpio_set_value(drv_data->scl_gpio, 0);
454 };
455 }
456
457 /* restore i2c pin state to MPPs: */
458 pinctrl_select_state(pc, drv_data->i2c_mpp_state);
459 }
460
461 /*
462 * Trigger controller soft reset
463 * This register is write only, with none of the bits defined.
464 * So any value will do.
465 * 0x1 just seems more intuitive than 0x0 ...
466 */
467 writel(0x1, drv_data->reg_base + drv_data->reg_offsets.soft_reset);
468 /* wait for i2c controller to complete reset: */
469 udelay(100);
470 /*
471 * need to proceed to the data stop condition generation clause.
472 * This is needed after clock toggling to put the i2c slave
473 * in the correct state.
474 */
475 fallthrough;
476
477 case MV64XXX_I2C_ACTION_RCV_DATA_STOP:
478 drv_data->msg->buf[drv_data->byte_posn++] =
479 readl(drv_data->reg_base + drv_data->reg_offsets.data);
480 if (!drv_data->atomic)
481 drv_data->cntl_bits &= ~MV64XXX_I2C_REG_CONTROL_INTEN;
482 writel(drv_data->cntl_bits | MV64XXX_I2C_REG_CONTROL_STOP,
483 drv_data->reg_base + drv_data->reg_offsets.control);
484 drv_data->block = 0;
485 if (drv_data->errata_delay)
486 udelay(5);
487
488 wake_up(&drv_data->waitq);
489 break;
490
491 case MV64XXX_I2C_ACTION_INVALID:
492 default:
493 dev_err(&drv_data->adapter.dev,
494 "mv64xxx_i2c_do_action: Invalid action: %d\n",
495 drv_data->action);
496 drv_data->rc = -EIO;
497 fallthrough;
498 case MV64XXX_I2C_ACTION_SEND_STOP:
499 if (!drv_data->atomic)
500 drv_data->cntl_bits &= ~MV64XXX_I2C_REG_CONTROL_INTEN;
501 writel(drv_data->cntl_bits | MV64XXX_I2C_REG_CONTROL_STOP,
502 drv_data->reg_base + drv_data->reg_offsets.control);
503 drv_data->block = 0;
504 wake_up(&drv_data->waitq);
505 break;
506 }
507 }
508
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki