Re: [RESEND PATCH v2 0/3] Bluetooth: power-on QCA6390 correctly

From: Bartosz Golaszewski
Date: Fri Dec 08 2023 - 05:57:10 EST


On Fri, Dec 8, 2023 at 11:32 AM Manivannan Sadhasivam
<manivannan.sadhasivam@xxxxxxxxxx> wrote:
>
> On Fri, Dec 08, 2023 at 10:09:33AM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > Resending with all maintainers in CC.
> >
> > Patch 1 is just a typo fix as we're already touching this bindings. The
> > second patch adds more regulator definitions and enforces them for the
> > QCA6390 model. The final patch enables the power sequence for the BT
> > module of QCA6390 in the hci_qca driver.
> >
>
> Is bluetooth fully functional without handling WLAN specific resources like
> regulators, enable GPIO? When I checked last time, the chip requires both
> Bluetooth and WLAN resources to become fully operational.
>

WLAN-specific regulators for PCIe are enabled anyway but the WLAN
enable GPIO is low and the relevant pin function is not even
configured. I can confirm Bluetooth is functional.

I too thought we'd need a common power-sequence here but Abel pointed
out that neither RB5 nor X13s require it, it's only needed in later
models.

Bart

> - Mani
>
> > v1 -> v2:
> > - squashed the two bluetooth patches into one
> > - changed the naming convention for the RFA regulators to follow the
> > existing ones
> > - added dt-bindings patches
> >
> > Bartosz Golaszewski (3):
> > dt-bindings: net: bluetooth: qualcomm: fix a typo
> > dt-bindings: net: bluetooth: qualcomm: add regulators for QCA6390
> > Bluetooth: qca: run the power-on/off sequence for QCA6390 too
> >
> > .../net/bluetooth/qualcomm-bluetooth.yaml | 26 ++++++++++++++++++-
> > drivers/bluetooth/hci_qca.c | 14 +++++++++-
> > 2 files changed, 38 insertions(+), 2 deletions(-)
> >
> > --
> > 2.40.1
> >
> >
>
> --
> மணிவண்ணன் சதாசிவம்