Re: [PATCH V3] nvmem: brcm_nvram: store a copy of NVRAM content

[Srinivas Kandagatla]

On 08/12/2023 11:25, Rafał Miłecki wrote:
> On 2023-12-08 12:15, Srinivas Kandagatla wrote:
> > Thank you for the patch,
> >
> > On 02/11/2023 06:28, Rafał Miłecki wrote:
> > > From: Rafał Miłecki <rafal@xxxxxxxxxx>
> > >
> > > This driver uses MMIO access for reading NVRAM from a flash device.
> > > Underneath there is a flash controller that reads data and provides
> > > mapping window.
> > >
> > > Using MMIO interface affects controller configuration and may break real
> > > controller driver. It was reported by multiple users of devices with
> > > NVRAM stored on NAND.
> > >
> > > Modify driver to read & cache NVRAM content during init and use that
> > > copy to provide NVMEM data when requested. On NAND flashes due to their
> > > alignment NVRAM partitions can be quite big (1 MiB and more) while
> > > actual NVRAM content stays quite small (usually 16 to 32 KiB). To avoid
> > > allocating so much memory check for actual data length.
> > >
> > > Link: 
> > > https://lore.kernel.org/linux-mtd/CACna6rwf3_9QVjYcM+847biTX=K0EoWXuXcSMkJO1Vy_5vmVqA@xxxxxxxxxxxxxx/
> > > Fixes: 3fef9ed0627a ("nvmem: brcm_nvram: new driver exposing 
> > > Broadcom's NVRAM")
> >
> > Any reason not to add
> > Cc: <Stable@xxxxxxxxxxxxxxx>
> > ?
>
> Not really. I believe stable team would pick this fix anyway (thanks to
> the Fixes:) but doing
> Cc: stable@xxxxxxxxxxxxxxx
> is described as strongly preferred.
>
> Do you think you can just ammend my patch while applying it and add
> Cc: stable@xxxxxxxxxxxxxxx
> to it?
Will do.

--srini
>