drivers/iommu/intel/dmar.c:1050:35: warning: '%d' directive writing between 1 and 10 bytes into a region of size 9

From: kernel test robot
Date: Sun Dec 10 2023 - 05:34:09 EST

Next message: Greg Kroah-Hartman: "Re: [PATCH v2] PM / sleep: Mechanism to find source aborting kernel suspend transition"
Previous message: Cristian Ciocaltea: "Re: [PATCH 10/11] ASoC: amd: acp: Use correct DAI link ID for BT codec"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c527f5606aa545233a4d2c6d5c636ed82b8633ef
commit: 913432f217c843a69ff9d11a6474a7982033087b iommu/vt-d: Use IDA interface to manage iommu sequence id
date: 1 year, 5 months ago
config: x86_64-buildonly-randconfig-006-20230911 (https://download.01.org/0day-ci/archive/20231210/202312101801.kIufuSiV-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231210/202312101801.kIufuSiV-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312101801.kIufuSiV-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

include/linux/printk.h:517:9: note: in expansion of macro 'printk'
517 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~
include/linux/kern_levels.h:12:25: note: in expansion of macro 'KERN_SOH'
12 | #define KERN_WARNING KERN_SOH "4" /* warning conditions */
| ^~~~~~~~
include/linux/printk.h:517:16: note: in expansion of macro 'KERN_WARNING'
517 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/iommu/intel/dmar.c:471:17: note: in expansion of macro 'pr_warn'
471 | pr_warn(FW_BUG
| ^~~~~~~
In function 'warn_invalid_dmar',
inlined from 'map_iommu' at drivers/iommu/intel/dmar.c:988:3:
include/linux/kern_levels.h:5:25: warning: '%s' directive argument is null [-Wformat-overflow=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/printk.h:436:25: note: in definition of macro 'printk_index_wrap'
436 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~
include/linux/once_lite.h:19:25: note: in expansion of macro 'printk'
19 | func(__VA_ARGS__); \
| ^~~~
include/linux/once_lite.h:11:9: note: in expansion of macro 'DO_ONCE_LITE_IF'
11 | DO_ONCE_LITE_IF(true, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/printk.h:603:9: note: in expansion of macro 'DO_ONCE_LITE'
603 | DO_ONCE_LITE(printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
include/linux/printk.h:622:9: note: in expansion of macro 'printk_once'
622 | printk_once(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/kern_levels.h:12:25: note: in expansion of macro 'KERN_SOH'
12 | #define KERN_WARNING KERN_SOH "4" /* warning conditions */
| ^~~~~~~~
include/linux/printk.h:622:21: note: in expansion of macro 'KERN_WARNING'
622 | printk_once(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/iommu/intel/dmar.c:866:9: note: in expansion of macro 'pr_warn_once'
866 | pr_warn_once(FW_BUG
| ^~~~~~~~~~~~
In function 'warn_invalid_dmar',
inlined from 'dmar_validate_one_drhd' at drivers/iommu/intel/dmar.c:907:3:
include/linux/kern_levels.h:5:25: warning: '%s' directive argument is null [-Wformat-overflow=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/printk.h:436:25: note: in definition of macro 'printk_index_wrap'
436 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~
include/linux/once_lite.h:19:25: note: in expansion of macro 'printk'
19 | func(__VA_ARGS__); \
| ^~~~
include/linux/once_lite.h:11:9: note: in expansion of macro 'DO_ONCE_LITE_IF'
11 | DO_ONCE_LITE_IF(true, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/printk.h:603:9: note: in expansion of macro 'DO_ONCE_LITE'
603 | DO_ONCE_LITE(printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
include/linux/printk.h:622:9: note: in expansion of macro 'printk_once'
622 | printk_once(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/kern_levels.h:12:25: note: in expansion of macro 'KERN_SOH'
12 | #define KERN_WARNING KERN_SOH "4" /* warning conditions */
| ^~~~~~~~
include/linux/printk.h:622:21: note: in expansion of macro 'KERN_WARNING'
622 | printk_once(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/iommu/intel/dmar.c:866:9: note: in expansion of macro 'pr_warn_once'
866 | pr_warn_once(FW_BUG
| ^~~~~~~~~~~~
In function 'warn_invalid_dmar',
inlined from 'dmar_validate_one_drhd' at drivers/iommu/intel/dmar.c:885:3:
include/linux/kern_levels.h:5:25: warning: '%s' directive argument is null [-Wformat-overflow=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/printk.h:436:25: note: in definition of macro 'printk_index_wrap'
436 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~
include/linux/once_lite.h:19:25: note: in expansion of macro 'printk'
19 | func(__VA_ARGS__); \
| ^~~~
include/linux/once_lite.h:11:9: note: in expansion of macro 'DO_ONCE_LITE_IF'
11 | DO_ONCE_LITE_IF(true, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/printk.h:603:9: note: in expansion of macro 'DO_ONCE_LITE'
603 | DO_ONCE_LITE(printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
include/linux/printk.h:622:9: note: in expansion of macro 'printk_once'
622 | printk_once(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/kern_levels.h:12:25: note: in expansion of macro 'KERN_SOH'
12 | #define KERN_WARNING KERN_SOH "4" /* warning conditions */
| ^~~~~~~~
include/linux/printk.h:622:21: note: in expansion of macro 'KERN_WARNING'
622 | printk_once(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/iommu/intel/dmar.c:866:9: note: in expansion of macro 'pr_warn_once'
866 | pr_warn_once(FW_BUG
| ^~~~~~~~~~~~
drivers/iommu/intel/dmar.c: In function 'alloc_iommu':
>> drivers/iommu/intel/dmar.c:1050:35: warning: '%d' directive writing between 1 and 10 bytes into a region of size 9 [-Wformat-overflow=]
1050 | sprintf(iommu->name, "dmar%d", iommu->seq_id);
| ^~
drivers/iommu/intel/dmar.c:1050:30: note: directive argument in the range [0, 2147483647]
1050 | sprintf(iommu->name, "dmar%d", iommu->seq_id);
| ^~~~~~~~
drivers/iommu/intel/dmar.c:1050:9: note: 'sprintf' output between 6 and 15 bytes into a destination of size 13
1050 | sprintf(iommu->name, "dmar%d", iommu->seq_id);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function 'warn_invalid_dmar',
inlined from 'alloc_iommu' at drivers/iommu/intel/dmar.c:1035:3:
include/linux/kern_levels.h:5:25: warning: '%s' directive argument is null [-Wformat-overflow=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/printk.h:436:25: note: in definition of macro 'printk_index_wrap'
436 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~
include/linux/once_lite.h:19:25: note: in expansion of macro 'printk'
19 | func(__VA_ARGS__); \
| ^~~~
include/linux/once_lite.h:11:9: note: in expansion of macro 'DO_ONCE_LITE_IF'
11 | DO_ONCE_LITE_IF(true, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/printk.h:603:9: note: in expansion of macro 'DO_ONCE_LITE'
603 | DO_ONCE_LITE(printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
include/linux/printk.h:622:9: note: in expansion of macro 'printk_once'
622 | printk_once(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/kern_levels.h:12:25: note: in expansion of macro 'KERN_SOH'
12 | #define KERN_WARNING KERN_SOH "4" /* warning conditions */
| ^~~~~~~~
include/linux/printk.h:622:21: note: in expansion of macro 'KERN_WARNING'
622 | printk_once(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/iommu/intel/dmar.c:866:9: note: in expansion of macro 'pr_warn_once'
866 | pr_warn_once(FW_BUG
| ^~~~~~~~~~~~

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS
Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
Selected by [y]:
- DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n)

vim +1050 drivers/iommu/intel/dmar.c

1025
1026 static int alloc_iommu(struct dmar_drhd_unit *drhd)
1027 {
1028 struct intel_iommu *iommu;
1029 u32 ver, sts;
1030 int agaw = -1;
1031 int msagaw = -1;
1032 int err;
1033
1034 if (!drhd->reg_base_addr) {
1035 warn_invalid_dmar(0, "");
1036 return -EINVAL;
1037 }
1038
1039 iommu = kzalloc(sizeof(*iommu), GFP_KERNEL);
1040 if (!iommu)
1041 return -ENOMEM;
1042
1043 iommu->seq_id = ida_alloc_range(&dmar_seq_ids, 0,
1044 DMAR_UNITS_SUPPORTED - 1, GFP_KERNEL);
1045 if (iommu->seq_id < 0) {
1046 pr_err("Failed to allocate seq_id\n");
1047 err = iommu->seq_id;
1048 goto error;
1049 }
> 1050 sprintf(iommu->name, "dmar%d", iommu->seq_id);
1051
1052 err = map_iommu(iommu, drhd->reg_base_addr);
1053 if (err) {
1054 pr_err("Failed to map %s\n", iommu->name);
1055 goto error_free_seq_id;
1056 }
1057
1058 err = -EINVAL;
1059 if (cap_sagaw(iommu->cap) == 0) {
1060 pr_info("%s: No supported address widths. Not attempting DMA translation.\n",
1061 iommu->name);
1062 drhd->ignored = 1;
1063 }
1064
1065 if (!drhd->ignored) {
1066 agaw = iommu_calculate_agaw(iommu);
1067 if (agaw < 0) {
1068 pr_err("Cannot get a valid agaw for iommu (seq_id = %d)\n",
1069 iommu->seq_id);
1070 drhd->ignored = 1;
1071 }
1072 }
1073 if (!drhd->ignored) {
1074 msagaw = iommu_calculate_max_sagaw(iommu);
1075 if (msagaw < 0) {
1076 pr_err("Cannot get a valid max agaw for iommu (seq_id = %d)\n",
1077 iommu->seq_id);
1078 drhd->ignored = 1;
1079 agaw = -1;
1080 }
1081 }
1082 iommu->agaw = agaw;
1083 iommu->msagaw = msagaw;
1084 iommu->segment = drhd->segment;
1085
1086 iommu->node = NUMA_NO_NODE;
1087
1088 ver = readl(iommu->reg + DMAR_VER_REG);
1089 pr_info("%s: reg_base_addr %llx ver %d:%d cap %llx ecap %llx\n",
1090 iommu->name,
1091 (unsigned long long)drhd->reg_base_addr,
1092 DMAR_VER_MAJOR(ver), DMAR_VER_MINOR(ver),
1093 (unsigned long long)iommu->cap,
1094 (unsigned long long)iommu->ecap);
1095
1096 /* Reflect status in gcmd */
1097 sts = readl(iommu->reg + DMAR_GSTS_REG);
1098 if (sts & DMA_GSTS_IRES)
1099 iommu->gcmd |= DMA_GCMD_IRE;
1100 if (sts & DMA_GSTS_TES)
1101 iommu->gcmd |= DMA_GCMD_TE;
1102 if (sts & DMA_GSTS_QIES)
1103 iommu->gcmd |= DMA_GCMD_QIE;
1104
1105 raw_spin_lock_init(&iommu->register_lock);
1106
1107 /*
1108 * This is only for hotplug; at boot time intel_iommu_enabled won't
1109 * be set yet. When intel_iommu_init() runs, it registers the units
1110 * present at boot time, then sets intel_iommu_enabled.
1111 */
1112 if (intel_iommu_enabled && !drhd->ignored) {
1113 err = iommu_device_sysfs_add(&iommu->iommu, NULL,
1114 intel_iommu_groups,
1115 "%s", iommu->name);
1116 if (err)
1117 goto err_unmap;
1118
1119 err = iommu_device_register(&iommu->iommu, &intel_iommu_ops, NULL);
1120 if (err)
1121 goto err_sysfs;
1122 }
1123
1124 drhd->iommu = iommu;
1125 iommu->drhd = drhd;
1126
1127 return 0;
1128
1129 err_sysfs:
1130 iommu_device_sysfs_remove(&iommu->iommu);
1131 err_unmap:
1132 unmap_iommu(iommu);
1133 error_free_seq_id:
1134 ida_free(&dmar_seq_ids, iommu->seq_id);
1135 error:
1136 kfree(iommu);
1137 return err;
1138 }
1139

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Next message: Greg Kroah-Hartman: "Re: [PATCH v2] PM / sleep: Mechanism to find source aborting kernel suspend transition"
Previous message: Cristian Ciocaltea: "Re: [PATCH 10/11] ASoC: amd: acp: Use correct DAI link ID for BT codec"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]