Re: [PATCH] ASoC: Enable built-in microphone on Lenovo ThinkPad P14s Gen 4 (AMD)

[Mario Limonciello]

On 12/10/2023 19:52, Michael T. Kloos wrote:
> Added System Board to Quirks List using model number prefix.
> Replaced/Removed a duplicate entry in the list.
> Added Yellow Carp Coprocessor Revision number to PCI revision check.
>
> Signed-off-by: Michael T. Kloos <michael@xxxxxxxxxxxxxxxx>

NAK.

This is supposed to be supported by ACP 6.3 (Pink Sardine).  Did you 
enable that driver?

Can you please share more about your problem?

> ---
>   sound/soc/amd/yc/acp6x-mach.c | 2 +-
>   sound/soc/amd/yc/pci-acp6x.c  | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index d83cb6e4c62a..c08605d99bc9 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -56,7 +56,7 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>   		.driver_data = &acp6x_card,
>   		.matches = {
>   			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> -			DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21K5"),
>   		}
>   	},
>   	{
> diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
> index 7af6a349b1d4..694b8e313902 100644
> --- a/sound/soc/amd/yc/pci-acp6x.c
> +++ b/sound/soc/amd/yc/pci-acp6x.c
> @@ -162,6 +162,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
>   	/* Yellow Carp device check */
>   	switch (pci->revision) {
>   	case 0x60:
> +	case 0x63:
>   	case 0x6f:
>   		break;
>   	default: