Re: [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback

[Jiaxun Yang]

在2023年12月10日十二月 上午6:48，Yanteng Si写道：
> 在 2023/6/17 02:52, Conor Dooley 写道:
>> On Fri, Jun 16, 2023 at 12:31:26PM +0200, Krzysztof Kozlowski wrote:
>>> Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS,
>>> so checking for some other compatible does not make sense.  It cannot be
>>> bound to unsupported platform.
>>>
>>> Drop useless, incorrect (space in between) and undocumented compatible.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Might be worth noting that dropping it is required to allow the
>> new loongarch dts stuff to be functional with a sane set of compatibles.
>>
>> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Thank you Krzysztof for your work. when I am
> adding more devices support to stmmac, I found that your
> two patches seemed to be forgotten.
> Thomas, Jiaxun. Can the two patches get an Acked-by?
> My stmmac patch thread:
> <https://lore.kernel.org/loongarch/cover.1699533745.git 
> .siyanteng@xxxxxxxxxxx/T/#md3108d29a5efe71b27f4c5ccf5d0217571bf6586>

Acked-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>

Better to resend without RFC :-)

Thanks

> Thanks,
> Yanteng
>
>>
>> Cheers,
>> Conor.

-- 
- Jiaxun