Re: [PATCH] misc: nsm: remove selecting the non-existing config CBOR

[Alexander Graf]

On 11.12.23 08:42, Lukas Bulwahn wrote:
> Commit b9873755a6c8 ("misc: Add Nitro Secure Module driver") adds Nitro
> Security Module support, which selects the non-existing config CBOR.
>
> In the development of the commit, there was initially some code for CBOR
> independent of the driver, and the driver included this code with the line
> 'select CBOR'. This code for CBOR was later reduced to its bare minimum of
> functionality and included into the driver itself. The select CBOR remained
> unnoticed and was left behind without having any further purpose.
>
> Remove selecting the non-existing config CBOR.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>


Yikes. Thanks for the catch!

Reviewed-by: Alexander Graf <graf@xxxxxxxxxx>


Alex


> ---
>   drivers/misc/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 8932b6cf9595..4fb291f0bf7c 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -566,7 +566,6 @@ config NSM
>          tristate "Nitro (Enclaves) Security Module support"
>          depends on VIRTIO
>          select HW_RANDOM
> -       select CBOR
>          help
>            This driver provides support for the Nitro Security Module
>            in AWS EC2 Nitro based Enclaves. The driver exposes a /dev/nsm
> --
> 2.17.1



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879