Re: [PATCH] dt-bindings: iommu: rockchip: Add Rockchip RK3588

[Heiko Stübner]

Hi Andy,

Am Samstag, 9. Dezember 2023, 02:50:38 CET schrieb Andy Yan:
> From: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
> 
> Add a Rockchip RK3588 compatible
> 
> I split it from the vop2 patch series as suggested by Heiko[0]

correct, but something with the addresses did go wrong

# scripts/get_maintainer.pl -f Documentation/devicetree/bindings/iommu/
lists among the other people especially:

Joerg Roedel <joro@xxxxxxxxxx> (maintainer:IOMMU SUBSYSTEM)
Will Deacon <will@xxxxxxxxxx> (maintainer:IOMMU SUBSYSTEM)

as the maintainers for the iommu subsystem and I don't see them
in the recipient list.


Heiko



> Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> 
> [0]https://patchwork.kernel.org/project/dri-devel/patch/20231207080235.652719-1-andyshrk@xxxxxxx/
> 
> ---
> 
>  .../devicetree/bindings/iommu/rockchip,iommu.yaml     | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> index ba9124f721f1..621dde0e45d8 100644
> --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> @@ -19,9 +19,14 @@ description: |+
>  
>  properties:
>    compatible:
> -    enum:
> -      - rockchip,iommu
> -      - rockchip,rk3568-iommu
> +    oneOf:
> +      - enum:
> +          - rockchip,iommu
> +          - rockchip,rk3568-iommu
> +      - items:
> +          - enum:
> +              - rockchip,rk3588-iommu
> +          - const: rockchip,rk3568-iommu
>  
>    reg:
>      items:
>