Re: [PATCH 0/5] Improve AMD ACP Vangogh audio support for Steam Deck OLED

[Cristian Ciocaltea]

On 12/11/23 17:12, Emil Velikov wrote:
> On 2023/12/09, Cristian Ciocaltea wrote:
>> This patch series provides several fixes and improvements to AMD ACP drivers
>> targeting the Vangogh platform, as found on the Valve's new Steam Deck OLED.
>>
>> Although in theory the board should have been supported by both SOF and legacy
>> ACP drivers, as of next-20231208 the audio seems to be completely broken.
>>
>> Please note this only restores the legacy support, while SOF will be handled in
>> a separate series.
>>
>> Cristian Ciocaltea (5):
>>   ASoC: amd: vangogh: Drop conflicting ACPI-based probing
>>   ASoC: amd: vangogh: Allow probing ACP PCI when SOF is disabled
>>   ASoC: amd: vangogh: Switch to {RUNTIME,SYSTEM_SLEEP}_PM_OPS
>>   ASoC: amd: acp-config: Add missing MODULE_DESCRIPTION
>>   ASoC: amd: acp: Add missing MODULE_DESCRIPTION in mach-common
>>
> 
> If it were me, I'd drop the Fixes tag in the latter two patches since
> the warning is harmless and as-is it'll get into the -stable
> maintainers' list, who are already pretty swamped with patches.

Sure, I can drop them if there is a need for v2.

> Regardless, for the series:
> Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>

Thanks for the review,
Cristian

> HTH
> Emil