Re: [PATCH 3/3] hwmon: Add driver for Astera Labs PT516XX retimer

[Rob Herring]

On Tue, Dec 5, 2023 at 1:49 AM Cosmo Chou <chou.cosmo@xxxxxxxxx> wrote:
>
> This driver implements support for temperature monitoring of Astera Labs
> PT5161L series PCIe retimer chips.
>
> This driver implementation originates from the CSDK available at
> Link: https://github.com/facebook/openbmc/tree/helium/common/recipes-lib/retimer-v2.14
> The communication protocol utilized is based on the I2C/SMBus standard.
>
> Signed-off-by: Cosmo Chou <chou.cosmo@xxxxxxxxx>
> ---
>  Documentation/hwmon/index.rst   |   1 +
>  Documentation/hwmon/pt516xx.rst |  48 +++
>  MAINTAINERS                     |   8 +
>  drivers/hwmon/Kconfig           |  10 +
>  drivers/hwmon/Makefile          |   1 +
>  drivers/hwmon/pt516xx.c         | 648 ++++++++++++++++++++++++++++++++
>  6 files changed, 716 insertions(+)
>  create mode 100644 Documentation/hwmon/pt516xx.rst
>  create mode 100644 drivers/hwmon/pt516xx.c

> diff --git a/drivers/hwmon/pt516xx.c b/drivers/hwmon/pt516xx.c
> new file mode 100644
> index 000000000000..824798559fe1
> --- /dev/null
> +++ b/drivers/hwmon/pt516xx.c
> @@ -0,0 +1,648 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +
> +#include <linux/debugfs.h>
> +#include <linux/delay.h>
> +#include <linux/err.h>
> +#include <linux/i2c.h>
> +#include <linux/init.h>
> +#include <linux/hwmon.h>
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/of_device.h>

You probably don't need this header and the implicit includes it makes
are dropped now in linux-next. Please check what you actually need and
make them explicit.

Rob