Re: [PATCH] soc: ti: k3-socinfo: Add JTAG ID for J722S

[Andrew Davis]

On 12/11/23 7:26 AM, Vaishnav Achath wrote:
> Add JTAG ID info for the J722S SoC family to enable SoC detection.
>
> More details about this SoC can be found in the TRM:
> 	https://www.ti.com/lit/zip/sprujb3
>
> Signed-off-by: Vaishnav Achath <vaishnav.a@xxxxxx>
> ---

Simple enough,

Reviewed-by: Andrew Davis <afd@xxxxxx>

Although I do question our use of the J7x names. All of our parts here
also have a "Sitara AMxx" branding. For instance here we could call
this new device by its "AM67" name, then J784S4 renamed as AM69, etc.
Then we would have a consistent naming (internally we will have to deal
with the part name madness, but why expose that externally if we don't
have to).

Andrew

> Bootlog with changes:
> https://gist.github.com/vaishnavachath/23d859925277df9ccd628190e7c23371
>
>   drivers/soc/ti/k3-socinfo.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/ti/k3-socinfo.c b/drivers/soc/ti/k3-socinfo.c
> index 7517a9c8c8fa..59101bf7cf23 100644
> --- a/drivers/soc/ti/k3-socinfo.c
> +++ b/drivers/soc/ti/k3-socinfo.c
> @@ -42,6 +42,7 @@
>   #define JTAG_ID_PARTNO_J784S4		0xBB80
>   #define JTAG_ID_PARTNO_AM62AX		0xBB8D
>   #define JTAG_ID_PARTNO_AM62PX		0xBB9D
> +#define JTAG_ID_PARTNO_J722S		0xBBA0
>   
>   static const struct k3_soc_id {
>   	unsigned int id;
> @@ -56,6 +57,7 @@ static const struct k3_soc_id {
>   	{ JTAG_ID_PARTNO_J784S4, "J784S4" },
>   	{ JTAG_ID_PARTNO_AM62AX, "AM62AX" },
>   	{ JTAG_ID_PARTNO_AM62PX, "AM62PX" },
> +	{ JTAG_ID_PARTNO_J722S, "J722S" },
>   };
>   
>   static const char * const j721e_rev_string_map[] = {