Re: [PATCH v10 04/50] x86/cpufeatures: Add SEV-SNP CPU feature

[Paolo Bonzini]

On 12/13/23 14:36, Borislav Petkov wrote:
> > Sure, I only queued it because you gave Acked-by for 05/50 and this is an
> > obvious dependency.  I would like to get things in as they are ready
> > (whenever it makes sense), so if you want to include those two in the x86
> > tree for 6.8, that would work for me.
>
> It doesn't make sense to include them into 6.8 because the two alone are
> simply dead code in 6.8.

Why are they dead code?  X86_FEATURE_SEV_SNP is set automatically based 
on CPUID, therefore patch 5 is a performance improvement on all 
processors that support SEV-SNP.  This is independent of whether KVM can 
create SEV-SNP guests or not.

If this is wrong, there is a problem in the commit messages.

Paolo

> The plan is to put the x86 patches first in the next submission, I'll
> pick them up for 6.9 and then give you an immutable branch to apply the
> KVM bits ontop. This way it all goes together.