Re: [PATCH v1 1/1] mfd: intel-lpss: Fix the fractional clock divider flags

From: Lee Jones
Date: Wed Dec 13 2023 - 11:19:11 EST


On Wed, 13 Dec 2023, Andy Shevchenko wrote:

> On Wed, Dec 13, 2023 at 04:13:52PM +0000, Lee Jones wrote:
> > On Mon, 11 Dec 2023, Andy Shevchenko wrote:
>
> ...
>
> > > tmp = clk_register_fractional_divider(NULL, name, __clk_get_name(tmp),
> > > + 0, lpss->priv, 1, 15, 16, 15,
> > > CLK_FRAC_DIVIDER_POWER_OF_TWO_PS,
> > > - lpss->priv, 1, 15, 16, 15, 0,
> > > NULL);
> >
> > What an ugly interface. Intel-only too, right?
>
> Nope, de facto way how custom clocks are being introduced.
> See clk-provider.h for several similar APIs (that require an
> additional, custom, flags to be supplied).

This call only has 2 call-sites, both Intel.

Anyway, just checking to ensure both are being fixed-up.

--
Lee Jones [李琼斯]